[PATCH] D80915: [FileCheck] Implement * and / operators for ExpressionValue.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm marked an inline comment as done.
paulwalker-arm added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:518
+  expectOperationValueResult(operator/, MinInt64, 1, MinInt64);
+  expectOperationValueResult(operator/, static_cast<uint64_t>(MaxInt64)+1, -1,
+                             MinInt64);
----------------
jhenderson wrote:
> Same as above - 2's complement assumption.
I'm not sure what to do here.  With the current design of ExpressionValue the overflow scenarios change depending on whether you're 1s or 2s complement.  I started going down the path of making overflow reporting consistent (essentially making ExpressionValue a 65bit 1s complement number) but I'm worried this might not be what you want.

I could just not have tests for the cases where 1s complement differs from 2s complement, but that seems wrong, hence the request for guidance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80915/new/

https://reviews.llvm.org/D80915