[PATCH] D81369: [Alignment][NFC] Migrate AtomicExpandPass to Align
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 9 03:15:43 PDT 2020
gchatelet added a comment.
In D81369#2080923 <https://reviews.llvm.org/D81369#2080923>, @efriedma wrote:
> > I'm unsure about getAtomicOpAlign overloads that take AtomicRMWInst and AtomicCmpXchgInst, shouldn't getAlign provide the correct answer already?
>
> getAlign() on what? AtomicRMWInst and AtomicCmpXchgInst don't have a getAlign() method. (It might make sense to add.)
My bad, I should have read PR27168 more carefully before requesting comments. I've added the `getAlign()` methods and looped @jyknight in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81369/new/
https://reviews.llvm.org/D81369
More information about the llvm-commits
mailing list