[PATCH] D81450: [ObjectYAML][ELF] Add support for emitting the .debug_line section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:82-87
+      MinInstLength:  1
+      DefaultIsStmt:  1
+      LineBase:       1
+      LineRange:      14
+      OpcodeBase:     13
+      StandardOpcodeLengths: [ 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 ]
----------------
As a suggestion, how about you make these somewhat less default values. For example:

```
      MinInstLength:  1
      DefaultIsStmt:  2
      LineBase:       3
      LineRange:      4
      OpcodeBase:     5
      StandardOpcodeLengths: [ 0, 1, 2, 3, 4 ]
```

You could probably even do that for the other fields too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81450/new/

https://reviews.llvm.org/D81450