[PATCH] D80285: [mlir] make the bitwidth of device side index computations configurable

Tobias Gysi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 02:09:33 PDT 2020


gysit updated this revision to Diff 269436.
gysit marked an inline comment as done.
gysit edited the summary of this revision.
gysit added a comment.
Herald added a subscriber: msifontes.
Herald added a project: MLIR.

The update passes the options structure to the type converter and to the conversion pattern base class (replaces the llvm type converter customizations). I also extended the patch to the rocdl backend.

The downside of the patch is that I have to pass the lower to llvm options to all the patters. Theoretically it would also be possible to access the options via the type converter but most of them are not related to the type conversion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80285/new/

https://reviews.llvm.org/D80285

Files:
  mlir/include/mlir/Conversion/GPUToNVVM/GPUToNVVMPass.h
  mlir/include/mlir/Conversion/GPUToROCDL/GPUToROCDLPass.h
  mlir/include/mlir/Conversion/Passes.td
  mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
  mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVMPass.h
  mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
  mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
  mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
  mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir
  mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80285.269436.patch
Type: text/x-patch
Size: 34702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200609/a387115a/attachment.bin>


More information about the llvm-commits mailing list