[PATCH] D80765: [ELF] Handle bitcode comdat groups separately to deduplicate thinlto comdat sections

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/SymbolTable.h:66
 
+  // We link twice in thinlto.  Define a separate map of comdat groups for
+  // bitcode files to make sure the symbols are distinct fromt the ones found
----------------
Double space before "Define".


================
Comment at: lld/ELF/SymbolTable.h:67
+  // We link twice in thinlto.  Define a separate map of comdat groups for
+  // bitcode files to make sure the symbols are distinct fromt the ones found
+  // in object files
----------------
fromt -> from


================
Comment at: lld/ELF/SymbolTable.h:68
+  // bitcode files to make sure the symbols are distinct fromt the ones found
+  // in object files
+  llvm::DenseMap<llvm::CachedHashStringRef, const InputFile *>
----------------
Could you expand the comment to mention why it is important to distinct them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80765/new/

https://reviews.llvm.org/D80765