[PATCH] D81362: [Alignment][NFC] Deprecate dead code from CallingConvLower.h

Tue Jun 9 01:36:37 PDT 2020

gchatelet added a comment.

In D81362#2080266 <https://reviews.llvm.org/D81362#2080266>, @ctetreau wrote:

> It looks like this function isn't actually dead code. I'm getting a ton of deprecation warnings about it on my master build, and this build bot run from one commit after yours that fixed the build failure has a bunch: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/17308
>
> I thought the build bots built with -werror? How are these builds passing?

Thx for the heads up. I fixed it in rG49dd8e79913cc10676902fd2033a090758cf9b90 <https://reviews.llvm.org/rG49dd8e79913cc10676902fd2033a090758cf9b90>.

As for the bots, there's a difference in how the deprecated attribute is treated between GCC/Clang and MSVC.  For MSVC the warning triggers even if the faulty call is inside a deprecated method itself, it's not the case for Clang/GCC, so depending on which bot is running it triggers an error... or not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81362/new/

https://reviews.llvm.org/D81362