[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: clang/include/clang/Basic/TargetInfo.h:1333
+    return GridValues[gv];
+  }
+
----------------
I somehow believe `!GridValues` is the wrong way around. You should also initialize it directly to null so this makes more sense.

The return value and the type of gridvalues don't match, pick int or unsigned ;)


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:108
+    63         // GV_Warp_Size_Log2_MaskL
+};
+
----------------
Nits:
-`This is`
I don't understand the fixme, do we need that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80917/new/

https://reviews.llvm.org/D80917