[llvm] 7e58d0d - Revert "[arm][darwin] Don't generate libcalls for wide shifts on Darwin"

[Eli Friedman via llvm-commits]

Author: Eli Friedman
Date: 2020-06-08T16:37:29-07:00
New Revision: 7e58d0ded099f4928fd6612497a6662d4595674b

URL: https://github.com/llvm/llvm-project/commit/7e58d0ded099f4928fd6612497a6662d4595674b
DIFF: https://github.com/llvm/llvm-project/commit/7e58d0ded099f4928fd6612497a6662d4595674b.diff

LOG: Revert "[arm][darwin] Don't generate libcalls for wide shifts on Darwin"

This reverts commit 2ba016cd5ce50a3683d3e6c2c62f00e1cccfd8b5.

This is causing a failure on the clang-cmake-armv7-full bot, and there
are outstanding review comments.

Added: 
    

Modified: 
    llvm/lib/Target/ARM/ARMISelLowering.cpp
    llvm/test/CodeGen/ARM/shift_minsize.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cpp
index 680b3a438fd0..f163bd620f26 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -17956,8 +17956,7 @@ bool ARMTargetLowering::isCheapToSpeculateCtlz() const {
 }
 
 bool ARMTargetLowering::shouldExpandShift(SelectionDAG &DAG, SDNode *N) const {
-  return !Subtarget->hasMinSize() || Subtarget->isTargetWindows() ||
-         Subtarget->isTargetDarwin();
+  return !Subtarget->hasMinSize() || Subtarget->isTargetWindows();
 }
 
 Value *ARMTargetLowering::emitLoadLinked(IRBuilder<> &Builder, Value *Addr,

diff  --git a/llvm/test/CodeGen/ARM/shift_minsize.ll b/llvm/test/CodeGen/ARM/shift_minsize.ll
index 36434a248c4f..de7327ed3fcb 100644
--- a/llvm/test/CodeGen/ARM/shift_minsize.ll
+++ b/llvm/test/CodeGen/ARM/shift_minsize.ll
@@ -1,16 +1,11 @@
 ; RUN: llc -mtriple=arm-eabi        %s -o - | FileCheck %s
 ; RUN: llc -mtriple=thumbv7-windows %s -o - | FileCheck %s -check-prefix=CHECK-WIN
-; RUN: llc < %s -mtriple=aarch64-apple-darwin    | FileCheck %s -check-prefix=CHECK-DARWIN
 
 ; The Windows runtime doesn't have these.
 ; CHECK-WIN-NOT: __ashldi3
 ; CHECK-WIN-NOT: __ashrdi3
 ; CHECK-WIN-NOT: __lshrdi3
 
-; Darwin compiler-rt excludes these.
-; CHECK-DARWIN-NOT: __ashlti3
-; CHECK-DARWIN-NOT: __ashrti3
-
 define i64 @f0(i64 %val, i64 %amt) minsize optsize {
 ; CHECK-LABEL:   f0:
 ; CHECK:         bl  __aeabi_llsl