[PATCH] D81036: [OpenMP] Begin Adding Analysis Remarks for OpenMP Best Practises.

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 marked 2 inline comments as done.
jhuber6 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:425
+    return ACS.getCalledFunction();
+  }
+
----------------
I originally had this function take a function, find the fork_call or fork_teams, and return the callback argument if it existed. I had to take the logic out because otherwise I didn't have an instruction to get a debugloc for.

This doesn't handle debug options where the compiler will wrap the parallel region in another function.


================
Comment at: llvm/test/Transforms/OpenMP/shared_firstprivate_analysis.ll:125
+!77 = distinct !DILexicalBlock(scope: !68, file: !1, line: 13, column: 5)
+!78 = !DILocation(line: 13, column: 5, scope: !58)
----------------
Should I combine this into one giant file that just handles OpenMP Analysis stuff?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81036/new/

https://reviews.llvm.org/D81036