[PATCH] D81316: [lit] Include unexecuted tests in xUnit report

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/xunit-output/pass.ini:5
+
+[results]
----------------
yln wrote:
> jdenny wrote:
> > Do you know why this `results` is never tested?
> The only reason this is here is because the `class DummyFormat` from `dummy_format.py` (see above)  expects this.  This file has been copy&pasted :/ for a couple of tests and I wanted to avoid diverging this copy further.  (I already added the `required_feature` property.)
> 
> The `[results]` part is used by one of the copies of the file in another test:
> https://github.com/llvm/llvm-project/blob/master/llvm/utils/lit/tests/Inputs/test-data/metrics.ini#L6
> https://github.com/llvm/llvm-project/blob/master/llvm/utils/lit/tests/test-data.py#L10
Ah, it seems I misgrepped and overlooked that.  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81316/new/

https://reviews.llvm.org/D81316