[PATCH] D79300: [ELF] Demote lazy symbols relative to a discarded section to Undefined
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 14:58:49 PDT 2020
psmith accepted this revision.
psmith added a comment.
This revision is now accepted and ready to land.
LGTM, I don't have a better idea.
As I understand it, I don't think that we can detect this case when reading the object. As these symbols are global they could be referred to from outside the group, even another object file (references to a global from outside a group are permitted in ELF). If we scan the relocations in the object we can detect references to the discarded symbol from the object, but not the other objects. We'd be able to detect all relocations to local symbols.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79300/new/
https://reviews.llvm.org/D79300
More information about the llvm-commits
mailing list