[PATCH] D81419: [AArch64][GlobalISel] Legalize vector G_PTR_ADD and enable selection.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 14:25:18 PDT 2020


paquette added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-ptr-add.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -O0 -mtriple=aarch64-apple-ios -run-pass=instruction-select -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=IOS
+--- |
----------------
IOS prefix isn't used?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-ptr-add.mir:3-10
+--- |
+  target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
+
+  define i8* @ptr_add(i8* %in) { ret i8* undef }
+  define i8* @ptr_add_no_constant(i8* %in) { ret i8* undef }
+  define i8* @ptr_add_bad_imm(i8* %in) { ret i8* undef }
+  define i8* @ptr_add_vec(i8* %in) { ret i8* undef }
----------------
Do you actually need the IR here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81419/new/

https://reviews.llvm.org/D81419





More information about the llvm-commits mailing list