[PATCH] D81381: GlobalISel: Move some trivial MIRBuilder methods into the header

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added a comment.

In D81381#2080552 <https://reviews.llvm.org/D81381#2080552>, @arsenm wrote:

> In D81381#2080450 <https://reviews.llvm.org/D81381#2080450>, @aditya_nandakumar wrote:
>
> > > The construction APIs for MachineIRBuilder don't make much sense,
> >
> > What exactly do you mean by this? I agree with the latter about these trivial methods getting in the way.
>
>
> See D81382 <https://reviews.llvm.org/D81382>. I also think it's a problem that RegBankSelect and other backend users need to construct their own single purpose builders, when the builder is supposed to be maintaining CSE state for example


This is unfortunate. I haven't paid too much attention to RegBankSelect pass/APIs. Maybe we need to fix those as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81381/new/

https://reviews.llvm.org/D81381