[PATCH] D81270: [XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 12:08:25 PDT 2020
jasonliu marked 3 inline comments as done.
jasonliu added inline comments.
================
Comment at: llvm/lib/IR/DataLayout.cpp:450
+ case 'a':
+ ManglingMode = MM_XCOFF;
+ break;
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > This is an addition to the IR. Should there be a bitcode test?
> There should be an update to the LLVM Language Reference Manual.
>This is an addition to the IR. Should there be a bitcode test?
I added an unittest in IR, hope that's enough.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81270/new/
https://reviews.llvm.org/D81270
More information about the llvm-commits
mailing list