[PATCH] D59553: [WIP][LLD][ELF][DebugInfo] Use predefined value to mark debug address ranges pointing to deleted code.

Mon Jun 8 11:35:28 PDT 2020

dblaikie added a comment.

In D59553#2080357 <https://reviews.llvm.org/D59553#2080357>, @avl wrote:

> > I'd like to avoid adding a flag at all, if possible.
>
> without the flag there is a risk that some tools expecting 0(current behavior) would work incorrectly with -1/-2. 
>  I do not know whether that problem really exist. But, since we are changing current default behavior, that problem could arise.
>  Thus, the flag which could restore old behavior - looks useful.

Yeah, I just worry then it becomes another source of inconsistency between consumers/producers/etc. Perhaps we could name it in some way that's clear that it might be removed later - to encourage people to either reach out to us to explain their use case, or to invest a bit more in working with the new default behavior.

>> Is there already a clear case where a one-size-fits-all solution won't be sufficient?
> 
> I did not clearly get it. is "one-size-fits-all" means option which affects all tables(without special cases for debug_loc/debug_ranges)?

Sorry, by "one-size-fits-all" I just meant "without a flag to customize the behavior". ie: do we know of specific use cases where the proposed -1/-2 behavior is definitely not going to be usable (that would make the flag discussion easier/more clear)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553