[PATCH] D81410: [ELF][AArch64] Correct relocation codes for R_<CLS>_PLT32
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 11:35:27 PDT 2020
psmith added a comment.
Thanks for the comments. When I made the change I looked at:
Static relocation codes for ELF64 object files begin at (257); dynamic ones at (1024). Both (0) and (256) should be accepted as values of R_AARCH64_NONE, the null relocation.
Static relocation codes for ELF32 object files begin at [1]; dynamic ones at [180].
I couldn't find anything about a TLS range, but it looks like there is one being observed even if it isn't explicitly called out. Let me know if you've spotted it?
I'll check with my colleagues tomorrow as I'll need to get the ABI change approved before updating here. My preference would be to move before the TLS relocations but it is probably not the end of the world as I don't think that there is any tool that could guarantee the TLS relocations were in a certain range to make a simpler isTLSReloc check.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81410/new/
https://reviews.llvm.org/D81410
More information about the llvm-commits
mailing list