[PATCH] D80885: [VectorCombine] scalarizeBinop - support an all-constant src vector operand

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 11:35:25 PDT 2020


spatel accepted this revision.
spatel added a comment.

LGTM - with ConstantExpr and grammar nit fixed.



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:345
+
+  // Bail for single insertion if its a load.
+  // TODO: Handle this once getVectorInstrCost can cost for load/stores.
----------------
its -> it is


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80885/new/

https://reviews.llvm.org/D80885





More information about the llvm-commits mailing list