[PATCH] D81108: [AArch64] Fix ldst-opt of multiple disjunct subregs.

Mon Jun 8 11:02:55 PDT 2020

fhahn added a comment.

In D81108#2077860 <https://reviews.llvm.org/D81108#2077860>, @efriedma wrote:

> LGTM with one minor question.

Thanks Eli!

>> I think the way we choose rename registers prevents using a register that is defined by the same instruction we are renaming. I can see if I can add a test case for that.
> 
> Did you ever come up with a testcase for this?

I pushed a test with an LDP with an undef operand in 22c2dc5931a73eebf2a2e2b2d7a8cf757907dc3e <https://reviews.llvm.org/rG22c2dc5931a73eebf2a2e2b2d7a8cf757907dc3e>. The undef register would be the next one to pick, but it is skipped (because it is also a def). Was that what you had in mind?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81108/new/

https://reviews.llvm.org/D81108