[PATCH] D75751: [AArch64][SVE] Implement structured load intrinsics
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 11:02:52 PDT 2020
c-rhodes marked 2 inline comments as done.
c-rhodes added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1461
+
+ ReplaceUses(SDValue(N, NumVecs), SDValue(Load, 1));
+ CurDAG->RemoveDeadNode(N);
----------------
sdesmalen wrote:
> sdesmalen wrote:
> > Is the above statement correct when having just replaced `SDValue(N, NumVecs-1)` in the loop above?
> Sorry, never mind that comment, I now see it is taking the chain from Load, not N.
> Can you add a comment clarifying this though? (that it is copying the chain here)?
Yeah it's just copying the chain, agree it's confusing using `NumVecs` as the index, I've updated it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75751/new/
https://reviews.llvm.org/D75751
More information about the llvm-commits
mailing list