[PATCH] D81296: [PDB] Defer public serialization until PDB writing

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

I'm not familiar with the PDB writing, but a scan of the code itself seemed fine.



================
Comment at: llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp:43
   std::vector<PSHashRecord> HashRecords;
   std::array<support::ulittle32_t, (IPHR_HASH + 32) / 32> HashBitmap;
   std::vector<support::ulittle32_t> HashBuckets;
----------------
I see this was just moved, but if the goal is to compute ceil(IPHR_HASH / 32) then I think +31 instead of +32 would be enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81296/new/

https://reviews.llvm.org/D81296