[PATCH] D75751: [AArch64][SVE] Implement structured load intrinsics

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 09:56:56 PDT 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM if you can add the extra comment.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1461
+
+  ReplaceUses(SDValue(N, NumVecs), SDValue(Load, 1));
+  CurDAG->RemoveDeadNode(N);
----------------
sdesmalen wrote:
> Is the above statement correct when having just replaced `SDValue(N, NumVecs-1)` in the loop above?
Sorry, never mind that comment, I now see it is taking the chain from Load, not N.
Can you add a comment clarifying this though? (that it is copying the chain here)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75751/new/

https://reviews.llvm.org/D75751





More information about the llvm-commits mailing list