[PATCH] D81308: [Matrix] Use TileInfo to create tiled loop nest for matrix multiply.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 09:56:50 PDT 2020


fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1196
+
+    Builder.SetInsertPoint(TI.RowLoopHeader->getTerminator());
+    Type *TileVecTy =
----------------
LuoYuanke wrote:
> Line 1194 and 1196 seems unnecessary. The insert point is specified in line 1202.
Nice catch, thanks! Seems like a leftover from earlier iterations. Removed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81308/new/

https://reviews.llvm.org/D81308





More information about the llvm-commits mailing list