[PATCH] D81167: [CodeGen] Fix nullptr crash in tryConvertSVEWideCompare
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 07:38:25 PDT 2020
sdesmalen added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11411
+ if (!Imm)
+ return SDValue();
----------------
Is it better to add the condition `&& isa<ConstantSDNode>(Comparator.getOperand(0))`on line 11366? Then at this point we can just `assert(Imm && "Did not find a valid immediate");`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81167/new/
https://reviews.llvm.org/D81167
More information about the llvm-commits
mailing list