[PATCH] D78568: [DAGCombine] Fix bug in load scalarization

Mon Jun 8 07:38:22 PDT 2020

frasercrmck added inline comments.
Herald added a subscriber: ecnelises.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17241
+  // compute an address to load only the extracted element as a scalar.
+  if (VecEltVT.getSizeInBits() < 8)
+    return SDValue();
----------------
foad wrote:
> I think using `.isByteSized` would be more obvious and more correct, since it would catch cases like i12 which also can't be handled by indexing.
Yes, that's a good point

(sigh: just realised that I didn't click "submit" on this one)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78568/new/

https://reviews.llvm.org/D78568