[PATCH] D81109: llvm-link: Add support for archive files as inputs.

Mon Jun 8 07:05:28 PDT 2020

jsjodin added a comment.

In D81109#2072453 <https://reviews.llvm.org/D81109#2072453>, @jdoerfert wrote:

> In D81109#2072395 <https://reviews.llvm.org/D81109#2072395>, @jsjodin wrote:
>
> > In D81109#2072178 <https://reviews.llvm.org/D81109#2072178>, @jdoerfert wrote:
> >
> > > Can you add a test for a broken archive.
> >
> >
> > Sure, I can use a non-archive file as an archive. I should also see what happens if .ll files are used inside an archive, I remember something bad happened when I tried it at some point.
>
>
> A test and, if possible, an error message is probably preferable to "something bad" ;)

Yes, I want it to work with .ll files as well, but there is an issue with memory buffers not being null terminated when they are supposed to be. I'm looking into this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109