[PATCH] D81356: [ObjectYAML] Add support for error handling in DWARFYAML. NFC.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Okay, approach looks fine. Just my comments about function renaming and the error handler to address then.



================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:333
 
-using EmitFuncType = void (*)(raw_ostream &, const DWARFYAML::Data &);
+using EmitFuncType = Error (*)(raw_ostream &, const DWARFYAML::Data &);
 
----------------
Higuoxing wrote:
> The `EmitDebugXXXX` functions have to have same type.
Right, I see, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81356/new/

https://reviews.llvm.org/D81356