[PATCH] D81147: [MC] Generate .debug_rnglists in the 64-bit DWARF format [5/7]

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 01:03:02 PDT 2020


ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:31
 # DUMP:       .debug_aranges contents:
-# DUMP-NEXT:  Address Range Header: length = 0x0000000000000034, format = DWARF64, version = 0x0002, cu_offset = 0x0000000000000000, addr_size = 0x08, seg_size = 0x00
+# DUMP-NEXT:  Address Range Header: length = 0x0000000000000044, format = DWARF64, version = 0x0002, cu_offset = 0x0000000000000000, addr_size = 0x08, seg_size = 0x00
+# DUMP-NEXT:  [0x0000000000000000,  0x0000000000000001)
----------------
jhenderson wrote:
> Up to you, but you could probably simplify this line, by deleting everything after `format = DWARF64`
That was my initial variant, but later I decided to extend the check to avoid potential cases when the format is `DWARF64`, but the data is malformed, e.g. if the emitting of `cu_offset` was not fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81147/new/

https://reviews.llvm.org/D81147





More information about the llvm-commits mailing list