[PATCH] D81056: [Support] Replace 'DisableColors' boolean with 'ColorMode' enum

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 01:02:59 PDT 2020


jhenderson added a comment.

In D81056#2076778 <https://reviews.llvm.org/D81056#2076778>, @JDevlieghere wrote:

> With the new approach this change isn't strictly necessary for D81058 <https://reviews.llvm.org/D81058> to work, but I still think it's an (small) improvement over the status quo. I'm happy to either land or abandon the patch, whatever the community feels is most desirable.


I'm always a fan of replacing `bool` arguments with a useful `enum`, so I'm happy if you think there's still some use in the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81056/new/

https://reviews.llvm.org/D81056





More information about the llvm-commits mailing list