[PATCH] D80220: [VPlan] Add & use VPValue indices for VPWidenGEPRecipe (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 269056.
fhahn added a comment.

In D80220#2078222 <https://reviews.llvm.org/D80220#2078222>, @gilr wrote:

> The patch LGTM, any reason not to include the base pointer?


I initially thought it might make things easier to do base ptr/indices separately, but it turned out handling the base ptr in the patch as well was not much extra work. Updated!

We still use GEP->clone() for the case where the GEP is loop invariant. It would probably be best to do that in a follow-on patch. Same for perhaps storing InBounds directly in the recipe as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80220/new/

https://reviews.llvm.org/D80220

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/lib/Transforms/Vectorize/VPlan.h
  llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80220.269056.patch
Type: text/x-patch
Size: 5426 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200607/fa87f08c/attachment.bin>