[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 6 14:25:11 PDT 2020
DiggerLin marked 2 inline comments as done.
DiggerLin added a comment.
in order not to let this patch too big, I will create NFC patch to clean up the AsmPrinter::emitLinkage.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:432
case GlobalValue::InternalLinkage:
if (MAI->hasDotLGloblDirective())
OutStreamer->emitSymbolAttribute(GVSym, MCSA_LGlobal);
----------------
jasonliu wrote:
> XCOFF only. Clean up needed. Please also check if we could remove this property from MAI.
hasDotLGloblDirective only use here. in order not to let the patch too big . I will remove hasDotLGloblDirective and DotLGloblDirective in new NFC patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75866/new/
https://reviews.llvm.org/D75866
More information about the llvm-commits
mailing list