[PATCH] D81325: [APInt] set all bits for getBitsSetWithWrap if loBit == hiBit

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 6 07:59:48 PDT 2020


shchenz added a comment.

In D81325#2078182 <https://reviews.llvm.org/D81325#2078182>, @lebedev.ri wrote:

> I assume all PPC usages of this function is happy with the change?
>  It is also used in GlobalISel's `LegalizerHelper::lowerInsert()`, is it also okay with this?




  APInt MaskVal = APInt::getBitsSetWithWrap(
      DstTy.getSizeInBits(), Offset + InsertTy.getSizeInBits(), Offset);

I am thinking the change will not impact the above use as `InsertTy.getSizeInBits()` should not be 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81325/new/

https://reviews.llvm.org/D81325





More information about the llvm-commits mailing list