[PATCH] D80562: AMDGPU/GlobalISel: Start rewriting load/store legality rules

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa accepted this revision.
kerbowa added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:188
+
 // Any combination of 32 or 64-bit elements up to 1024 bits, and multiples of
 // v2s16.
----------------
Or 128 or 256-bit elements right?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:237
+    // Flat addresses may contextually need to be split to 32-bit parts if they
+    // may alias scratch depending on the ssubtarget.
+    return 128;
----------------
subtarget.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80562/new/

https://reviews.llvm.org/D80562