[PATCH] D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 15:11:00 PDT 2020


efriedma added a comment.

In general, I'd like to strongly discourage directly checking endian::system_endianness(), in favor of using the endian-sensitive read/write helpers from llvm/Support/Endian.h.  For example, you can copy_n from an endian::ulittle64_t* to a uint64_t*.  Using a distinct codepath for big-endian means more code, and that code gets less testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80272/new/

https://reviews.llvm.org/D80272





More information about the llvm-commits mailing list