[PATCH] D19908: [X86] Support the "ms-hotpatch" attribute.

Fri Jun 5 14:03:11 PDT 2020

aganea added a comment.

This patch didn't apply cleanly on latest, for the reasons mentionned by @cdavis5x here: https://reviews.llvm.org/D19908#518374
I ended up reimplementing the end-feature of this patch in D81301 <https://reviews.llvm.org/D81301>.
@cdavis5x Could you please take a look at let me know if that patch covers what you intended to do?

================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:97
+      // continue, only to run into the jump back into the patch.
+      OutStreamer->emitFill(Subtarget->is64Bit() ? 128 : 64, 0xcc);
+    }
----------------
I'm not sure why this was done here. I vaguely recall that older versions of MSVC (VS2012 or before) were generating this kind of fill, but this was then replaced by `/FUNCTIONPADMIN` in the linker (it is supported by LLD).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D19908/new/

https://reviews.llvm.org/D19908