[PATCH] D81246: [SCEV] ScalarEvolution::createSCEV(): Instruction::Or: drop completely bogus no-wrap flag detection

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 13:28:05 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

If LHS is an AddRec, the result must be an AddRec because the add gets folded into the "Start".  And that AddRec must have the same wrapping behavior: if it didn't, that would mean getMinTrailingZeros returned the wrong value.  Therefore, setting the nowrap flags like this should be legal.

But sure, we can just specify the flags to getAddExpr itself, and let the SCEV construction code do the rest. LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81246/new/

https://reviews.llvm.org/D81246





More information about the llvm-commits mailing list