[PATCH] D81124: lld: use modern library search ordering

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 12:55:00 PDT 2020


MaskRay added a comment.

In D81124#2077251 <https://reviews.llvm.org/D81124#2077251>, @compnerd wrote:

> rGe78431354bcb6bec5be9adf4ea37d860445f8c16 <https://reviews.llvm.org/rGe78431354bcb6bec5be9adf4ea37d860445f8c16>


You need to retain `Reviewed by:` and `Differential Revision:` to close the revision automatically when you push the commit to master.

  arcfilter () {
    arc amend
    git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
  }

`Reviewed By: ` is considered important by some people (https://lists.llvm.org/pipermail/llvm-dev/2020-January/137889.html). You should keep the tag. (I started to use `--date=now` because some people find author date != committer date annoying. The committer date is usually what people care.))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81124/new/

https://reviews.llvm.org/D81124





More information about the llvm-commits mailing list