[PATCH] D80992: [CostModel] Unify getArithmeticInstrCost

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 10:36:17 PDT 2020


dfukalov marked an inline comment as done.
dfukalov added a comment.

AMDGPU part LGTM,
let's wait a couple of days to allow others to take a look



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:439
+    // implementation tries to generate legalize and scalarization costs.
+    return BaseT::getArithmeticInstrCost(Opcode, Ty, TTI::TCK_RecipThroughput,
+                                         Opd1Info, Opd2Info,
----------------
I see, this override is needed since scheme is changing. I guess I should review this place after you'll complete RFC


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80992/new/

https://reviews.llvm.org/D80992





More information about the llvm-commits mailing list