[PATCH] D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: msifontes.

In D80258#2053986 <https://reviews.llvm.org/D80258#2053986>, @Jing wrote:

> I found there are some internal tests (on diagnostics) that rely on column zero being the first column.
>  I am not so sure whether we should adopt that behavior and change API (i.e. treating only row zero being an unknown location) or fix the tests.


We should just fix the tests. zero line/zero column seems like a good enough indicator that it is the beginning of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80258/new/

https://reviews.llvm.org/D80258