[PATCH] D81145: [MC] Generate a compilation unit in the 64-bit DWARF format [3/7]

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:983
+  // The 4 (8 for DWARF64) byte offset to the debug abbrevs from the start of
+  // the .debug_abbrev, it is at the start of that section so this is zero.
   if (AbbrevSectionSymbol == nullptr)
----------------
ikudrin wrote:
> jhenderson wrote:
> > Probably should be a full stop instead of a comma on this line, though I'm not 100% sure I entirely follow the comment as a whole.
> I've added a full stop. For my taste, it sounds OK, meaning that we know that we generate only one block of data, which is at the start of the section, so the real offset to that data is zero. Probably, Mach-O does not require a relocation for that case, so the raw value can be used.
Yeah, it's still a bit confusing to me too. The ambiguities in the second sentence I think are what I'm tripping over - it is unclear to me what "it" and "this" are in that context.

But maybe out of scope for this patch - if someone comes up with a good phrasing & wants to replace it - just commit that directly/separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81145/new/

https://reviews.llvm.org/D81145