[PATCH] D81146: [MC] Generate .debug_aranges in the 64-bit DWARF format [4/7]

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 08:52:28 PDT 2020


ikudrin added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:913-916
+    MCOS->emitSymbolValue(InfoSectionSymbol, OffsetSize,
                           asmInfo->needsDwarfSectionOffsetDirective());
   else
+    MCOS->emitIntValue(0, OffsetSize);
----------------
jhenderson wrote:
> As mentioned elsewhere, there are two code paths here, but only one seems to be tested. Do we need another test case?
`MachO/gen-dwarf64.s` is extended to cover another code path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81146/new/

https://reviews.llvm.org/D81146





More information about the llvm-commits mailing list