[PATCH] D81148: [MC] Fix DWARF forms for 64-bit DWARFv3 files [6/7]

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:4
+# RUN: llvm-mc -g -dwarf-version 3 -dwarf64 -triple x86_64 %s -filetype=obj -o %t3.o
+# RUN: llvm-readobj -r %t3.o | FileCheck --check-prefixes=REL %s
+# RUN: llvm-dwarfdump -v %t3.o | FileCheck --check-prefixes=DUMP,DUMP3 %s
----------------
MaskRay wrote:
> `--check-prefixes=REL,REL3`
Thanks!


================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:18
 # REL5-NEXT:     R_X86_64_64 .debug_rnglists 0x14
 # REL:         Section ({{[0-9]+}}) .rela.debug_aranges {
 # REL-NEXT:      R_X86_64_64 .debug_info 0x0
----------------
MaskRay wrote:
> This `REL` can be `REL-NEXT` to prevent the accidental omission of `check-prefixes=REL,REL3`
There are other relocations for the `.debug_info` section which I did not want to check because they are irrelevant to the changes of these patches. So, I probably would not add the `-NEXT` suffix, if you do not mind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81148/new/

https://reviews.llvm.org/D81148