[PATCH] D81149: [MC] Generate .debug_frame in the 64-bit DWARF format [7/7]

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1621
+  if (IsDwarf64)
+    // DWARF64 mark
+    Streamer.emitInt32(dwarf::DW_LENGTH_DWARF64);
----------------
MaskRay wrote:
> Your other patches don't seem to mention `DWARF64 mark`. You may drop a comment
Hmm, I checked and found similar comments before each line where I added emitting `DW_LENGTH_DWARF64`. Do you think it is better to remove all such comments or keep all of them?


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1760-1766
+    emitAbsValue(Streamer, offset, OffsetSize);
   } else if (!asmInfo->doesDwarfUseRelocationsAcrossSections()) {
     const MCExpr *offset =
         MakeStartMinusEndExpr(context, SectionStart, cieStart, 0);
-    emitAbsValue(Streamer, offset, 4);
+    emitAbsValue(Streamer, offset, OffsetSize);
   } else {
+    Streamer.emitSymbolValue(&cieStart, OffsetSize,
----------------
jhenderson wrote:
> There are three cases here that have been modified, but I don't see three test cases?
The case in the middle was for the Mach-O target, so I've updated the corresponding test to cover it. The other two paths are already covered by `ELF/gen-dwarf64.s`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81149/new/

https://reviews.llvm.org/D81149