[PATCH] D81144: [MC] Generate .debug_line in the 64-bit DWARF format [2/7]
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 5 08:18:38 PDT 2020
ikudrin marked an inline comment as done.
ikudrin added inline comments.
================
Comment at: llvm/lib/MC/MCDwarf.cpp:487
+ emitAbsValue(*MCOS,
+ MakeStartMinusEndExpr(context, *LineStartSym, *LineEndSym,
+ UnitLengthBytes),
----------------
jhenderson wrote:
> ikudrin wrote:
> > jhenderson wrote:
> > > Aside: I think this function may be misnamed - shouldn't it be `MakeEndMinusStartExpr`?
> > Looks like you are right. Would you like to prepare the patch?
> I would, but I already have too many patches in progress to keep track of, in relation to my debug line work at the moment, so if somebody else is able to fix it, that would be great.
Well, I would also postpone changing that, in particular, to avoid interfering with this set of patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81144/new/
https://reviews.llvm.org/D81144
More information about the llvm-commits
mailing list