[PATCH] D81224: [AMDGPU] Fix failure in VCC spilling
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 5 06:34:09 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:939
+ getMatchingSuperReg(getSubReg(SuperReg, SplitParts[FirstPart]),
+ AMDGPU::sub0, &AMDGPU::SGPR_64RegClass);
+ }
----------------
Don't you just need to change SGPR_64RegClass to SReg_64RegClass (or maybe the XEXEC variant?)
================
Comment at: llvm/test/CodeGen/AMDGPU/spill-special-sgpr.mir:2
+# RUN: llc -mtriple=amdgcn -mcpu=gfx900 -verify-machineinstrs -run-pass=prologepilog %s -o - | FileCheck -check-prefix=CHECK %s
+# RUN: llc -mtriple=amdgcn -mcpu=gfx1010 -mattr=-wavefrontsize32,+wavefrontsize64 -verify-machineinstrs -run-pass=prologepilog %s -o - | FileCheck -check-prefix=CHECK %s
+
----------------
-mattr=-wavefrontsize32,+wavefrontsize64 is unnecessary since wave32 is the default
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81224/new/
https://reviews.llvm.org/D81224
More information about the llvm-commits
mailing list