[PATCH] D81217: [ObjectYAML][DWARF] Support emitting .debug_ranges section in ELFYAML.
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jun  5 03:49:11 PDT 2020
    
    
  
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one remaining suggestion.
================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-ranges.yaml:215-216
+      Entries:
+        - LowOffset:  0x0000000000000001
+          HighOffset: 0x0000000000000002
+
----------------
Up to you, but the "don't pad unnecessarily" comment also applies to these addresse and the `AddrSize` field in this and the other examples. I don't mind if you think it's useful to have them there though.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81217/new/
https://reviews.llvm.org/D81217
    
    
More information about the llvm-commits
mailing list