[PATCH] D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

@llitchev There are two guiding principles for this commit:

- The LLVM dialect must not have anything that is not present in LLVM IR
- Separation of concerns makes conversions simpler: if we can do the tanh expansion on the standard dialect (without involving type conversions necessary for std->llvm), we absolutely should for the sake of maintainability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75509/new/

https://reviews.llvm.org/D75509