[PATCH] D81215: [VE] Support branch instructions in MC layer

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 02:42:41 PDT 2020


kaz7 planned changes to this revision.
kaz7 marked an inline comment as done.
kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:71
   llvm_unreachable("Invalid cond code");
+  return VECC::UNKNOWN;
 }
----------------
kaz7 wrote:
> simoll wrote:
> > return after unreachable
> Yes.  Similar to above comment.  Maybe it is safe to remove return this time, though.
Well, it must be safe now (at the time to upstreaming).  I'll remove them.  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81215/new/

https://reviews.llvm.org/D81215





More information about the llvm-commits mailing list