[PATCH] D81219: [VE] Support logical operation instructions in MC layer

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 02:09:22 PDT 2020


simoll added a comment.

LGTM with one style nit.



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:694
+             Name.startswith("cmov.d.") || Name.startswith("cmov.s.")) {
+    bool ICC = Name[5] == 'l' || Name[5] == 'w' ? true : false;
+    Mnemonic = parseCC(Name, 7, Name.size(), ICC, false, NameLoc, Operands);
----------------
Redundant `?:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81219/new/

https://reviews.llvm.org/D81219





More information about the llvm-commits mailing list