[PATCH] D81215: [VE] Support branch instructions in MC layer

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

Looks good save some nits.



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:840
+OperandMatchResultTy VEAsmParser::parseMEMAsOperand(OperandVector &Operands) {
+  LLVM_DEBUG(dbgs() << "parseMEMAsOpeand\n");
+  const AsmToken &Tok = Parser.getTok();
----------------
typo


================
Comment at: llvm/lib/Target/VE/VE.h:51-66
+  CC_AF = 0 + 6,     // Never
+  CC_G = 1 + 6,      // Greater
+  CC_L = 2 + 6,      // Less
+  CC_NE = 3 + 6,     // Not Equal
+  CC_EQ = 4 + 6,     // Equal
+  CC_GE = 5 + 6,     // Greater or Equal
+  CC_LE = 6 + 6,     // Less or Equal
----------------
The only real change here is the addition of `UNKNOWN`? I guess we should undo the unrelated indentation change for the other enum entries here.


================
Comment at: llvm/lib/Target/VE/VE.h:258
   llvm_unreachable("Invalid cond code");
+  return VECC::CC_AF;
 }
----------------
Return after unreachable?


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:71
   llvm_unreachable("Invalid cond code");
+  return VECC::UNKNOWN;
 }
----------------
return after unreachable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81215/new/

https://reviews.llvm.org/D81215