[PATCH] D79479: [MLIR] Add complex addition and substraction to the standard dialect

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.
Herald added a subscriber: msifontes.
Herald added a project: MLIR.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:1388
+struct BinaryComplexOperands {
+  Value lhsReal, lhsImag, rhsReal, rhsImag;
+};
----------------
rriddle wrote:
> I would prefer you just use std::complex<Value> instead.
@frgossen: ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79479/new/

https://reviews.llvm.org/D79479